Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandbox: restore old WINCH trap #11922

Merged
merged 1 commit into from Aug 25, 2021
Merged

sandbox: restore old WINCH trap #11922

merged 1 commit into from Aug 25, 2021

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 25, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Given this happens in a fork, this probably doesn't matter too much in practice. This just makes the code a bit "safer" and follow good practice.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Aug 25, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 merged commit 16ad584 into Homebrew:master Aug 25, 2021
@Bo98 Bo98 deleted the sandbox-winch branch August 25, 2021 21:34
@MikeMcQuaid
Copy link
Member

Looks good, thanks @Bo98!

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants