Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump rubocop from 1.19.1 to 1.20.0 in /Library/Homebrew #11926

Merged
merged 4 commits into from Aug 27, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 26, 2021

Bumps rubocop from 1.19.1 to 1.20.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.20

New features

Bug fixes

  • #10033: Fix an incorrect auto-correct for Style/BlockDelimiters when there is a comment after the closing brace and using method chanin. (@​koic)
  • #6630: Updated Style/CommentAnnotation to be able to handle multiword keyword phrases. (@​dvandersluis)
  • #7836: Update Style/BlockDelimeters to add begin...end when converting a block containing rescue or ensure to braces. (@​dvandersluis)
  • #10031: Fix a false positive for Style/HashExcept when comparing with hash value. (@​koic)

Changes

Changelog

Sourced from rubocop's changelog.

1.20.0 (2021-08-26)

New features

Bug fixes

  • #10033: Fix an incorrect auto-correct for Style/BlockDelimiters when there is a comment after the closing brace and using method chanin. ([@​koic][])
  • #6630: Updated Style/CommentAnnotation to be able to handle multiword keyword phrases. ([@​dvandersluis][])
  • #7836: Update Style/BlockDelimeters to add begin...end when converting a block containing rescue or ensure to braces. ([@​dvandersluis][])
  • #10031: Fix a false positive for Style/HashExcept when comparing with hash value. ([@​koic][])

Changes

Commits
  • 536d986 Cut 1.20
  • 6516c18 Update Changelog
  • 60552ea Update a changelog entry
  • baba941 [Fix #9580] Add New Cop to Enforce Bundler Gem filename (#9903)
  • 016838b [Fix #7836] Update Style/BlockDelimeters to add begin...end when conver...
  • 5ad72a1 Clarify relationship between Layout/MultilineMethodArgumentLineBreaks and `...
  • 2bab715 [Fix #6630] Updated Style/CommentAnnotation to be able to handle multiword ...
  • 150f285 Refactor AnnotationComment into an actual class representing an annotation ...
  • 9ff50d1 Make Lint/Debugger aware of debug.rb
  • 7b0358f [Fix #10031] Fix a false positive for Style/HashExcept
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.19.1...v1.20.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Bumping Gemfile dependencies ruby Pull requests that update Ruby code labels Aug 26, 2021
Comment on lines +58 to +61

Bundler/GemFilename:
Exclude:
- "utils/gems.rb"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set up the Bundler/GemFilename to simply ignore the utils/gems.rb. That way, we can get the gems.rb check without needing to rename this file which we know isn't a gem file, anyway.

To be honest, we probably don't even need this cop but I figured there's no harm in keeping it around in case someone tries to make some weird changes to the Gemfile setup that we don't want.

@Rylan12 Rylan12 merged commit 6da8630 into master Aug 27, 2021
@Rylan12 Rylan12 deleted the dependabot/bundler/Library/Homebrew/rubocop-1.20.0 branch August 27, 2021 04:11
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Bumping Gemfile dependencies outdated PR was locked due to age ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants