Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch: fix --bottle-tag when unbottled on host system #11927

Merged
merged 2 commits into from Sep 1, 2021

Conversation

FnControlOption
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This can be tested by opening a formula, deleting/commenting out the bottle sha256 for your macOS version, and then running brew fetch --bottle-tag=<different macOS tag> <formula name>

@MikeMcQuaid
Copy link
Member

This can be tested by opening a formula, deleting/commenting out the bottle sha256 for your macOS version, and then running brew fetch --bottle-tag=<different macOS tag> <formula name>

@FnControlOption Can you elaborate on the use-case for this? Thanks!

@FnControlOption
Copy link
Contributor Author

Well, you're not gonna like this but... my use case for this was to download the molten-vk Catalina bottle so I could install it on a Mojave system. The project I was working on still didn't build though, so it wasn't really useful in the end.

On a slightly unrelated note, what other alternatives are there to download bottles? I can't find any direct download links at https://github.com/orgs/Homebrew/packages

@MikeMcQuaid
Copy link
Member

deleting/commenting out the bottle sha256 for your macOS version

Does this still work if you don't do this?

Well, you're not gonna like this but... my use case for this was to download the molten-vk Catalina bottle so I could install it on a Mojave system.

I don't mind this being indirectly enabled but just not supported directly.

I can't find any direct download links at https://github.com/orgs/Homebrew/packages

formulae.brew.sh provides some links in the API. They may or may not work for a direct curl, though, as you have to set headers etc.

@FnControlOption
Copy link
Contributor Author

deleting/commenting out the bottle sha256 for your macOS version

Does this still work if you don't do this?

Yes, this should continue functioning as before. I assumed you're already on a newer macOS where most formulae are already bottled, so I included that step in case you couldn't find an unbottled formula for your macOS version.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, thanks @FnControlOption!

@MikeMcQuaid MikeMcQuaid merged commit 7c37a34 into Homebrew:master Sep 1, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants