cleanup: allow users to specify formulae to skip cleaning #11931
Conversation
|
Review period will end on 2021-08-30 at 10:05:52 UTC. |
BrewTestBot
added
the
waiting for feedback
carlocab
changed the title
carlocab
force-pushed
the
cleanup-formulae
branch
from
bef3428
to
d789a50
Compare
This allows users to set `HOMEBREW_NO_CLEANUP_FORMULAE` to a comma-separated list of formulae that `brew` will refuse to clean with `brew cleanup`. We currently allow a less granular version of this with `HOMEBREW_NO_INSTALL_CLEANUP`. All this changes is how much control users have over what is and isn't cleaned. Fixes Homebrew#11924.
carlocab
force-pushed
the
cleanup-formulae
branch
from
d789a50
to
a7133d2
Compare
|
Review period ended. |
BrewTestBot
removed
the
waiting for feedback
| def skip_clean_formula?(f) | ||
| return false if Homebrew::EnvConfig.no_cleanup_formulae.blank? | ||
|
|
||
| skip_clean_formulae = Homebrew::EnvConfig.no_cleanup_formulae.split(",") |
There was a problem hiding this comment.
I wonder if it's worth adding this behaviour into EnvConfig itself under the type? We also seem to alternate between comma and space separated on our configuration; might be worth doubling down on one?
There was a problem hiding this comment.
We actually also have an option that takes a path to a file that specifies the list. We should probably only pick one approach, but this will require a deprecation cycle.
There was a problem hiding this comment.
Or: we support both space-separated and comma-separated in the cases where we can use both (e.g. environment variables), document consistently and only use comma-separated in the cases where only it works (e.g. arguments)
There was a problem hiding this comment.
Yep, fine with me. I'll try to look into it.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This allows users to set
HOMEBREW_NO_CLEANUP_FORMULAEto acomma-separated list of formula that
brewwill refuse to clean withbrew cleanup.We currently allow a less granular version of this with
HOMEBREW_NO_INSTALL_CLEANUP. All this changes is how much controlusers have over what is and isn't cleaned.
Fixes #11924.