Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] change default value of $HOMEBREW_BAT_CONFIG_PATH #11974

Closed
Freed-Wu opened this issue Sep 5, 2021 · 1 comment · Fixed by #11975
Closed

[suggestion] change default value of $HOMEBREW_BAT_CONFIG_PATH #11974

Freed-Wu opened this issue Sep 5, 2021 · 1 comment · Fixed by #11975
Labels
features New features outdated PR was locked due to age

Comments

@Freed-Wu
Copy link

Freed-Wu commented Sep 5, 2021

Provide a detailed description of the proposed feature

$ bat --config-dir
/home/XXX/.config/bat

bat has changed its default config path.

However, according to https://docs.brew.sh/Manpage#environment

HOMEBREW_BAT_CONFIG_PATH
Use this as the bat configuration file.

Default: $HOME/.bat/config.

What is the motivation for the feature?

/

How will the feature be relevant to at least 90% of Homebrew users?

/

What alternatives to the feature have been considered?

/

@Freed-Wu Freed-Wu added the features New features label Sep 5, 2021
@carlocab
Copy link
Member

carlocab commented Sep 5, 2021

Thanks for the report.

Homebrew doesn't actually set this default value; it uses bat's default whenever you don't set HOMEBREW_BAT_CONFIG_PATH.

The only thing that needs changing is here:

HOMEBREW_BAT_CONFIG_PATH: {
description: "Use this as the `bat` configuration file.",
default_text: "`$HOME/.bat/config`.",

Can you open a pull request for that?

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features New features outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants