Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing_formula.rb: don't disable texlive #12085

Merged
merged 2 commits into from
Sep 18, 2021
Merged

missing_formula.rb: don't disable texlive #12085

merged 2 commits into from
Sep 18, 2021

Conversation

danielnachun
Copy link
Member

@danielnachun danielnachun commented Sep 17, 2021 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The reasons for disallowing texlive on macOS have been irrelevant for many years now and we have a PR to add it: Homebrew/homebrew-core#83738.

@BrewTestBot
Copy link
Member

Review period will end on 2021-09-20 at 18:21:02 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 17, 2021
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Sep 18, 2021
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Sep 18, 2021
@danielnachun danielnachun added the critical Critical change which should be shipped as soon as possible. label Sep 18, 2021
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 18, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@danielnachun danielnachun merged commit bfd6050 into Homebrew:master Sep 18, 2021
@danielnachun danielnachun mentioned this pull request Sep 18, 2021
Closed
6 tasks
@MikeMcQuaid
Copy link
Member

This isn't really critical @danielnachun. In this case I'm 👍🏻 on the change but I'd like to provide feedback to PRs like this based on the existing workflow before they hand in future.

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2021
@danielnachun danielnachun deleted the macos_enable_texlive branch July 11, 2022 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danielnachun @BrewTestBot @MikeMcQuaid @carlocab