Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_cellar_checks: fix edge case handling in check_binary_arches #12092

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Currently, if formula foo ships both universal and non-native
binaries and foo is on both allowlists, then brew audit --strict
errors out with an empty error message:

❯ brew audit --strict foo
foo:
  *
Error: 1 problem in 1 formula detected

Let's fix this (admittedly obscure) corner case by returning early when
a formula is present on both allowlists.

Currently, if formula `foo` ships both universal and non-native
binaries and `foo` is on both allowlists, then `brew audit --strict`
errors out with an empty error message:

    ❯ brew audit --strict foo
    foo:
      *
    Error: 1 problem in 1 formula detected

Let's fix this (admittedly obscure) corner case by returning early when
a formula is present on both allowlists.
@BrewTestBot
Copy link
Member

Review period will end on 2021-09-21 at 17:08:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 20, 2021
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 21, 2021
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 21, 2021
@carlocab carlocab merged commit 1f3de1d into Homebrew:master Sep 21, 2021
@carlocab carlocab deleted the binary-arch-edge-case branch September 21, 2021 09:20
@Tabbbbs

This comment has been minimized.

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants