archive: delete

[FnControlOption]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

These lines in Archive#upload_bottles:

      directory = if formula_tap_repo
        "bottles-#{tap.repo}"
      else
        "bottles"
      end

came from this method in Utils::Bottles::Bintray (which was deleted in b914411):

      def self.repository(tap = nil)
        if tap.nil? || tap.core_tap?
          "bottles"
        else
          "bottles-#{tap.repo}"
        end
      end

However, upload_bottles does not have a tap parameter, and tap.repo should be replaced with formula_tap_repo.

[MikeMcQuaid]

Thanks @FnControlOption! Are you using this to upload to the Internet Archive or did you just notice it? I'm wondering if this code should be removed if it was broken and no-one noticed.

[FnControlOption]

Not using it. Found this with brew typecheck. I agree that this can safely be deleted if no one has opened issue about this from when b914411 was pushed to master to now. However, I don't know exactly how this works, so I'll defer to you.

[MikeMcQuaid]

@FnControlOption I reckon just open a pull request to remove this. Thanks!

[MikeMcQuaid]

(or update this one to do so, even better)

[MikeMcQuaid]

Thanks again @FnControlOption!