utils/curl: fix flag handling #12177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
6 tasks
|
Review period skipped due to |
BrewTestBot
approved these changes
Oct 4, 2021
carlocab
approved these changes
Oct 4, 2021
MikeMcQuaid
reviewed
Oct 5, 2021
| @@ -304,7 +304,13 @@ def curl_http_content_headers_and_checksum( | |||
| ) | |||
| file = Tempfile.new.tap(&:close) | |||
|
|
|||
| specs = specs.flat_map { |option, argument| ["--#{option.to_s.tr("_", "-")}", argument] } | |||
| specs = specs.flat_map do |option, argument| | |||
There was a problem hiding this comment.
I don't really understand what the code below is doing or why it's needed. A comment might be worth adding?
There was a problem hiding this comment.
It tries to convert specs to options, but made the strong assumption they are all key value. When I added a specs[:insecure] = true elsewhere it broke this, which seems to be invoked on brew audit --online.
There was a problem hiding this comment.
Ah, gotcha. Maybe worth adding a comment explaining this?
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Homebrew/homebrew-core#86415 (comment)