Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: add DBus session address to browser env #12889

Merged
merged 1 commit into from Feb 17, 2022
Merged

utils: add DBus session address to browser env #12889

merged 1 commit into from Feb 17, 2022

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Feb 17, 2022

Otherwise brew deps --graph will fail to launch Firefox on Linux (and probably all other browsers or utilities that rely on DBus for IPC).

Fixes #12881.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2022-02-18 at 04:06:29 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 17, 2022
carlocab
carlocab reviewed Feb 17, 2022
View reviewed changes
bin/brew Outdated Show resolved Hide resolved
brew: keep DBus session address in env
cbac7a3 
Otherwise `brew deps --graph` will fail to launch Firefox on Linux.

Fixes Homebrew#12881.
@gromgit gromgit changed the title brew: keep DBus session address in env brew: add DBus session address to browser env Feb 17, 2022
@carlocab carlocab added the critical Critical change which should be shipped as soon as possible. label Feb 17, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 17, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@carlocab carlocab changed the title brew: add DBus session address to browser env utils: add DBus session address to browser env Feb 17, 2022
@carlocab carlocab merged commit bdf25a5 into Homebrew:master Feb 17, 2022
@gromgit gromgit deleted the keep_dbus_env branch February 17, 2022 10:09
MikeMcQuaid
MikeMcQuaid reviewed Feb 17, 2022
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks @gromgit!

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@dawidd6 dawidd6 dawidd6 approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew deps --graph curl fails to open Firefox on Linux
5 participants
@gromgit @BrewTestBot @MikeMcQuaid @dawidd6 @carlocab