Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-cmd/bump: Ignore Repology if the livecheck uses GithubLatest #12900

Merged
merged 2 commits into from Feb 21, 2022
Merged

dev-cmd/bump: Ignore Repology if the livecheck uses GithubLatest #12900

merged 2 commits into from Feb 21, 2022

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 19, 2022 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • I got frustrated when I fixed the build and test failures for v2ray 5.0.3 homebrew-core#95430 only to have the audit step say it was a pre-release.
  • Repology can list versions that are GitHub pre-releases. Pre-release versions of software are things we don't generally want to ship: there's an audit specifically for that.
  • This fixes brew bump to not mark a Repology version as the newest if the formula's livecheck strategy is GithubLatest. If the livecheck doesn't exist, or its update strategy is something other than GithubLatest, Repology's reported package version is respected.

@BrewTestBot
Copy link
Member

Review period will end on 2022-02-22 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 19, 2022
@issyl0
dev-cmd/bump: Ignore Repology if the livecheck uses GithubLatest
0a91c40 
- I got frustrated when I fixed the build and test failures for
  https://github.com/Homebrew/homebrew-core/pull /95430 only to have the
  audit step say it was a pre-release.
- Repology can list versions that are GitHub pre-releases. Pre-release
  versions of software are things we don't generally want to ship:
  there's an audit specifically for that.
- This fixes `brew bump` to not mark a Repology version as the newest if
  the formula's livecheck strategy is `GithubLatest`. If the livecheck
  doesn't exist, or its update strategy is something other than
  `GithubLatest`, Repology's reported package version is respected.
@issyl0 issyl0 force-pushed the bump-no-prereleases-based-on-livecheck branch from 32c189b to 0a91c40 Compare February 19, 2022 21:41
@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Feb 20, 2022
SMillerDev
SMillerDev approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Feb 20, 2022
nandahkrishna
nandahkrishna approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this seems fine to me. Should we also consider adding a message indicating why a formula wasn't bumped (or was bumped to the livecheck version and not the newer Repology version) when the --open-pr flag is passed?

@issyl0
Copy link
Member Author

issyl0 commented Feb 20, 2022 •
edited

Thanks @nandahkrishna. I added a message. I'm open to suggestions on the wording!

issyl0 in lacerta in /opt/homebrew on bump-no-prereleases-based-on-livecheck 
❯ brew bump v2ray --open-pr                              
==> v2ray
Current formula version:  4.44.0
Latest livecheck version: 4.44.0
Latest Repology version:  5.0.3
Open pull requests:       v2ray 5.0.3 (https://github.com/Homebrew/homebrew-core/pull/95430)
v2ray was not bumped because either:
 - it has no new versions, or
 - its Repology version is not the latest release on GitHub.

@issyl0 issyl0 force-pushed the bump-no-prereleases-based-on-livecheck branch 2 times, most recently from fece6d8 to aaa101e Compare February 20, 2022 17:23
@issyl0 issyl0 force-pushed the bump-no-prereleases-based-on-livecheck branch from aaa101e to b10c5be Compare February 20, 2022 17:53
@issyl0 @nandahkrishna
dev-cmd/bump: Tell the user why we didn't bump a package
9ad3a9c 
Co-authored-by: Nanda H Krishna <me@nandahkrishna.com>
@issyl0 issyl0 force-pushed the bump-no-prereleases-based-on-livecheck branch from b10c5be to 9ad3a9c Compare February 20, 2022 17:56
@issyl0
Copy link
Member Author

issyl0 commented Feb 20, 2022

New output:

❯ brew bump v2ray --open-pr
==> v2ray
Current formula version:  4.44.0
Latest livecheck version: 4.44.0
Latest Repology version:  5.0.3
Open pull requests:       v2ray 5.0.3 (https://github.com/Homebrew/homebrew-core/pull/95430)
v2ray was not bumped to the Repology version because that version is not the latest release on GitHub.

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Feb 20, 2022
nandahkrishna
nandahkrishna approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Feb 21, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 21, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 21, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member

This seems like a great middle ground. Thanks @issyl0. CC @samford for post-merge thoughts but merging for now to avoid any more errant automation.

@MikeMcQuaid MikeMcQuaid merged commit 2dc375a into Homebrew:master Feb 21, 2022
@issyl0 issyl0 deleted the bump-no-prereleases-based-on-livecheck branch February 21, 2022 10:36
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@SMillerDev SMillerDev SMillerDev approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@nandahkrishna nandahkrishna nandahkrishna approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@issyl0 @BrewTestBot @MikeMcQuaid @SMillerDev @nandahkrishna