Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debian7: force usage of brewed ca-certificates #12907

Merged
merged 1 commit into from Feb 22, 2022
Merged

debian7: force usage of brewed ca-certificates #12907

merged 1 commit into from Feb 22, 2022

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Feb 21, 2022 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@BrewTestBot
Copy link
Member

Review period will end on 2022-02-22 at 21:51:59 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 21, 2022
@iMichka
Copy link
Member Author

iMichka commented Feb 21, 2022

Right now this would be enabled by HOMEBREW_ON_DEBIAN7, which is a first step to fix this at least on our CI.
We might want to implement extra logic at one point for a more specific list of Linux, maybe based on the system version of curl / certificated.

@iMichka iMichka requested a review from Bo98 February 21, 2022 21:53
@iMichka iMichka mentioned this pull request Feb 21, 2022
Closed
iMichka added a commit to iMichka/homebrew-developer that referenced this pull request Feb 21, 2022
@iMichka
debian7: don't install ca-certificates
830bdb7 
This will be handled by Homebrew/brew#12907
and test-bot
@iMichka iMichka mentioned this pull request Feb 21, 2022
Closed
6 tasks
Bo98
Bo98 approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this approach makes sense to me.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Feb 21, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 21, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

MikeMcQuaid
MikeMcQuaid reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Good once the undef is removed.

MikeMcQuaid
MikeMcQuaid approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iMichka!

@MikeMcQuaid MikeMcQuaid merged commit 01506f1 into Homebrew:master Feb 22, 2022
@iMichka iMichka deleted the certs branch February 22, 2022 19:25
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@Bo98 Bo98 Bo98 approved these changes

@BrewTestBot BrewTestBot Awaiting requested review from BrewTestBot

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iMichka @BrewTestBot @MikeMcQuaid @Bo98