Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to clarify why it is upgrading dependents #12922

Merged
merged 1 commit into from Feb 25, 2022

Conversation

rdp
Copy link

@rdp rdp commented Feb 23, 2022

  • [ x] Have you followed the guidelines in our Contributing document?
  • [x ] Have you checked to ensure there aren't other open Pull Requests for the same change?
  • [x ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example. There weren't any close tempates to model after.
  • [x ] Have you successfully run brew style with your changes locally?
  • [ x] Have you successfully run brew typecheck with your changes locally?
  • [ x] Have you successfully run brew tests with your changes locally? Though unclear since terminal line endings get mixed up?

The motivation for this is: if I update "x" brew might update seemingly unrelated apps (that aren't even dependencies), try and clarify why it does that. Suggestions welcome!

Homebrew/discussions#2179 (reply in thread)

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far but needs some style tweaks.

Library/Homebrew/upgrade.rb Outdated Show resolved Hide resolved
Library/Homebrew/upgrade.rb Outdated Show resolved Hide resolved
@rdp
Copy link
Author

rdp commented Feb 24, 2022

Oops, those look good, thanks!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @rdp!

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@MikeMcQuaid MikeMcQuaid merged commit 30d703d into Homebrew:master Feb 25, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants