Update uses of Formula.all/Cask::Cask.all
#12935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2022-03-01 at 13:27:16 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
force-pushed
the
all_tweaks
branch
from
f5591f3
to
2754f7c
Compare
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Mar 1, 2022
Rylan12
approved these changes
Mar 1, 2022
There was a problem hiding this comment.
Fine with me. I don't really understand why you're adding these switches if they don't do anything and are hidden but I guess it doesn't hurt anything.
What's the transition plan here? Shouldn't we put a warning or something now if in the future we'll be changing the default functionality?
Bo98
reviewed
Mar 1, 2022
@Rylan12 so we can start using them in our tooling now and save effort on forgetting these cases and breaking them when we deprecate later. |
Add some `--all` flags we'll eventually migrate to to ensure that we'll eventually require their usage to read all formulae. Where we need to do stuff later, add some comments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some
--allflags we'll eventually migrate to to ensure that we'll eventually require their usage to read all formulae. Where we need to do stuff later, add some comments.