Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/spec_helper: prevent stdin trashing #12967

Merged
merged 1 commit into from Mar 7, 2022

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Mar 6, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This fixes a situation where the output of brew tests will modify the stty attributes of the terminal and also cause test output to appear garbled with mishandled newlines.

Not entirely sure why this happens - I can't reproduce it outside of brew tests - but we should be doing this safe handling anyway, and we already to it for stdout and stderr.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Mar 6, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit 66c266a into Homebrew:master Mar 7, 2022
@Bo98 Bo98 deleted the tests-stdin branch March 7, 2022 13:17
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants