formula_installer: Fix --only-dependencies formula arch handling
#12968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For a formula with an architecture requirement and a user requesting `--only-dependencices` to be installed, this now proceeds to install the formula dependencies regardless of the requested formula architecture because the formula itself will never be installed. - The way dependencies and requirements are computed, the `depends_on :arch` is still a dependency, so it's in the list of formula dependencies to check and potentially install. Hence, we have to remove from the list the dependent from `recursive_requirements` with the same name as the formula so that there are no confusing unsatisfied requirements for the named formula when we don't need it to be installed. - I thought about why this might be, maybe it's because we can't guarantee that formula dependencies work on different architectures. But in that case they'd have their own architecture requirements, so we'd see the failure for them. So I don't know of any more reasons. Before: ```shell $ brew install --only-dependencies julia julia: The x86_64 architecture is required for this software. Error: julia: An unsatisfied requirement failed this build. ``` After: ```shell ❯ brew install --only-dependencies julia ==> Downloading [...] ==> Installing dependencies for julia: libnghttp2, mpfr and suite-sparse ```
|
Review period will end on 2022-03-08 at 00:00:00 UTC. |
BrewTestBot
added
the
waiting for feedback
issyl0
added
the
critical
BrewTestBot
removed
the
waiting for feedback
|
Review period skipped due to |
BrewTestBot
approved these changes
Mar 6, 2022
MikeMcQuaid
approved these changes
Mar 7, 2022
|
Thanks @issyl0! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?--only-dependencicesto be installed, this now proceeds to install the formula dependencies regardless of the requested formula architecture because the formula itself will never be installed.depends_on :archis still a dependency, so it's in the list of formula dependencies to check and potentially install. Hence, we have to remove from the list the dependent fromrecursive_requirementswith the same name as the formula so that there are no confusing unsatisfied requirements for the named formula when we don't need it to be installed.Before:
$ brew install --only-dependencies julia julia: The x86_64 architecture is required for this software. Error: julia: An unsatisfied requirement failed this build.After: