Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless attr_writer from FormulaInstaller #12969

Merged
merged 1 commit into from Mar 10, 2022

Conversation

hyuraku
Copy link
Contributor

@hyuraku hyuraku commented Mar 7, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

remove attr_writer from FormulaInstaller because the attr_writer was removed from test-bot after the PR Homebrew/homebrew-test-bot#792

@MikeMcQuaid
Copy link
Member

Thanks again @hyuraku!

@MikeMcQuaid MikeMcQuaid merged commit ff73e88 into Homebrew:master Mar 10, 2022
@hyuraku hyuraku deleted the remove_useless_attr_writer branch March 10, 2022 23:48
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants