Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linkage_checker: restrict RPATH test to --strict #12979

Merged
merged 1 commit into from Mar 10, 2022
Merged

linkage_checker: restrict RPATH test to --strict #12979

merged 1 commit into from Mar 10, 2022

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Mar 9, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This test is causing some rebuilds due to failed linkage upon upgrade.
That's a problem because rebuilds won't fix the problem that the RPATH
check identifies.

@carlocab
linkage_checker: restrict RPATH test to --strict
39923cd 
This test is causing some rebuilds due to failed linkage upon upgrade.
That's a problem because rebuilds won't fix the problem that the `RPATH`
check identifies.
@carlocab carlocab added the critical Critical change which should be shipped as soon as possible. label Mar 9, 2022
@carlocab carlocab mentioned this pull request Mar 9, 2022
Merged
7 tasks
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 merged commit 209c9b6 into Homebrew:master Mar 10, 2022
@carlocab carlocab deleted the rpath-strict-only branch March 10, 2022 00:03
@scpeters
Copy link
Member

thank you!

@scpeters scpeters mentioned this pull request Mar 10, 2022
Open
scpeters added a commit to gazebo-tooling/release-tools that referenced this pull request Mar 10, 2022
@scpeters
Revert "Set HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK for now (#656)"
89ec7cc 
This reverts commit e316d84.
This is no longer needed since Homebrew/brew#12979 was merged.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this pull request Mar 10, 2022
Merged
@MikeMcQuaid
Copy link
Member

Thanks @carlocab!

j-rivero pushed a commit to gazebo-tooling/release-tools that referenced this pull request Mar 16, 2022
@scpeters
Revert "Set HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK for now (#656)" (#660
0e4c042 
)

This reverts commit e316d84.
This is no longer needed since Homebrew/brew#12979 was merged.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carlocab @BrewTestBot @scpeters @MikeMcQuaid @Bo98