repair cask's fuzzy_search in search_casks

[hyuraku]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

related to #13028
repair Homebrew::Search::Extension.search_casks to use Cask.full_name instead of Tap.cask_tokens for fuzzy_search

1. before

brew search  docker-compose
==> Formulae
docker-compose                                                                       docker-compose-completion                                                            docker-completion

If you meant "docker-compose" specifically:
It was migrated from homebrew/cask to homebrew/core.

2. after

brew search  docker-compose
==> Formulae
docker-compose                                                                       docker-compose-completion                                                            docker-completion

==> Casks
docker-toolbox

If you meant "docker-compose" specifically:
It was migrated from homebrew/cask to homebrew/core.

[MikeMcQuaid]

I think doing results |= would be preferable to add more results even if there's only one. Thoughts?

[hyuraku]

I think doing results |= would be preferable to add more results even if there's only one. Thoughts?

I agree. I'll repair it.

[MikeMcQuaid]

Suggested change

	results = DidYouMean::SpellChecker.new(dictionary: cask_names).correct(string_or_regex)
	results = DidYouMean::SpellChecker.new(dictionary: cask_names)
	.correct(string_or_regex)

[MikeMcQuaid]

Suggested change

	end.uniq
	end

|= will already ensure uniqueness.

[hyuraku]

Without uniq, the search results will show duplicate cask names. Because result will include the same cask's full_name and one's cask_tokens

brew/Library/Homebrew/extend/os/mac/search.rb

Line 43 in 0758631

results.sort.map do |name|

without uniq

brew search dockertoolbox
==> Formulae
docker-ls

==> Casks
docker-toolbox docker-toolbox

with uniq

brew search dockertoolbox
==> Formulae
docker-ls

==> Casks
docker-toolbox

[MikeMcQuaid]

I see, in that case, what about doing += above given we're doing uniq here anyway?

[hyuraku]

@MikeMcQuaid
Could you review this PR?

[MikeMcQuaid]

Thanks again @hyuraku!