Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/Homebrew-Governance: State the election types for PLC and PL #13118

Merged
merged 1 commit into from Apr 11, 2022

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Apr 9, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

- A vote passed in 2021 on an amendment to use these election types (Homebrew#10637), but the changes to the governance document were only made in Homebrew/brew, not in Homebrew/homebrew-governance-private: https://github.com/Homebrew/brew/pull/13073/files#r844130115.
- When we copied over 2022's proposed changes ahead of the 2022 vote, the specific election voting methods were lost because these documents got out of sync.
- For the elections in 2022, we did use the voting methods as documented in the Homebrew/brew governance document (confirmed in Homebrew#13031 when I couldn't find the term on OpaVote), so let's reinstate them here to avoid confusion.
- Relates to Homebrew/governance-private#36.
@BrewTestBot
Copy link
Member

Review period will end on 2022-04-12 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 9, 2022
@Bo98
Copy link
Member

Bo98 commented Apr 10, 2022

Officially, governance changes only get merged here once approved by the membership.

@issyl0
Copy link
Member Author

issyl0 commented Apr 10, 2022

Yeah, that's why I've left it without merging. Technically this was a mess up last year (2021) and this reinstates what was there, but officially to the letter of the governance document it does need another vote. I'll ask the rest of the PLC next week.

@Bo98
Copy link
Member

Bo98 commented Apr 10, 2022

Here's a question: when exactly do governance changes apply? Could this amendment in theory be a part of the 2023 AGM, have its results announced first, and then the rest of the elections under the same AGM be under those rules?

@issyl0
Copy link
Member Author

issyl0 commented Apr 10, 2022

Bo is here with the awkward but excellent questions that I don’t immediately know the answers to. Maybe we’d need a special general meeting (extraordinary? EGM?) to vote on this ahead of 2023? 🤔 We really should have picked up this inconsistency in the two documents last year, whoops.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Apr 11, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 11, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member

In the AGM itself it was universally agreed that this could be merged without voting considering 1) it's what was already present 2) it's what we literally did for the votes for this AGM and 3) everyone agreed.

Thanks @issyl0!

@MikeMcQuaid MikeMcQuaid merged commit 26e4b67 into Homebrew:master Apr 11, 2022
@issyl0 issyl0 deleted the sync-governance-docs branch April 12, 2022 14:19
@github-actions github-actions bot added the outdated PR was locked due to age label May 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants