Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uses_from_macos: allow libxcrypt #13157

Merged
merged 1 commit into from Apr 27, 2022
Merged

uses_from_macos: allow libxcrypt #13157

merged 1 commit into from Apr 27, 2022

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Apr 18, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Homebrew/homebrew-core#99367

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Apr 18, 2022
@BrewTestBot
Copy link
Member

BrewTestBot commented Apr 18, 2022

Review period ended.

@Bo98 Bo98 changed the title uses_from_macos: whitelist libxcrypt uses_from_macos: allow libxcrypt Apr 18, 2022
@Bo98
Copy link
Member Author

Bo98 commented Apr 18, 2022

🐔 🥚

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me but is this technically provided by macOS or should it be ALLOWED_USES_FROM_MACOS_DEPS (or something else)?

@Bo98
Copy link
Member Author

Bo98 commented Apr 19, 2022

So this specific implementation isn't provided by macOS, nor does the dylib or header shadow anything from macOS by filename, but the functions that libxcrypt offer (e.g. crypt) are provided by macOS in libSystem.

I think making it keg-only is safer since there are some configure scripts that will do AC_CHECK_HEADERS(crypt.h) and either assume glibc or prioritise using that header over anything in the system.

@Bo98 Bo98 merged commit 58aa2e1 into Homebrew:master Apr 27, 2022
@Bo98 Bo98 deleted the libxcrypt branch April 27, 2022 14:40
@github-actions github-actions bot added the outdated PR was locked due to age label May 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants