Added --changed option to "brew tests" dev cmd #13158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
approved these changes
Apr 18, 2022
apainintheneck
force-pushed
the
tests-changed-switch
branch
from
77ded1d
to
46ea73a
Compare
MikeMcQuaid
reviewed
Apr 19, 2022
Library/Homebrew/dev-cmd/tests.rb
Outdated
Comment on lines
142
to
150
| raise UsageError, "The --only= argument requires a valid file or folder name!" if args.only | ||
|
|
||
| if args.changed? | ||
| opoo "Either no files have been changed from the master branch " \ | ||
| "or no tests are associated with the changed files!" | ||
| return | ||
| end |
There was a problem hiding this comment.
Suggested change
| raise UsageError, "The --only= argument requires a valid file or folder name!" if args.only | |
| if args.changed? | |
| opoo "Either no files have been changed from the master branch " \ | |
| "or no tests are associated with the changed files!" | |
| return | |
| end | |
| if args.only | |
| raise UsageError, "The --only= argument requires a valid file or folder name!" | |
| elsif args.changed? | |
| opoo "Either no files have been changed from the master branch " \ | |
| "or no tests are associated with the changed files!" | |
| return | |
| end |
Also: does the latter want to maybe be a UsageError too? Wondering if any other cases need handled, too.
There was a problem hiding this comment.
I can't think of any other use cases. It would also be possible to split that last warning into two messages. If brew tests --changed is called and no files have been changed, for whatever reason, that's probably a usage error. The other case where no tests directly correspond with the changed files isn't really a usage error imo.
There was a problem hiding this comment.
I decided to split those two up into a usage error and a warning. Also, the decision to use a guard clause was in response to the linter.
This option allows the user to run tests on all files that have been changed from the master branch.
apainintheneck
force-pushed
the
tests-changed-switch
branch
from
46ea73a
to
b7d8822
Compare
MikeMcQuaid
approved these changes
Apr 19, 2022
|
Thanks again @apainintheneck! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This option allows the user to run tests on only the files that have been changed in comparison with the master branch. It slots in between the
brew testsandbrew tests --only=filenamedev commands.Resolves #13146.