Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend/os/linux/keg_relocate: restore checking only GCC major versions #13174

Merged
merged 1 commit into from Apr 22, 2022
Merged

extend/os/linux/keg_relocate: restore checking only GCC major versions #13174

merged 1 commit into from Apr 22, 2022

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Apr 22, 2022

Only noticed this subtle behavioural change after merging. Let's restore the old comparison behaviour to avoid any unintended consequences (and use .major rather than .to_i to make it more obvious).

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Apr 22, 2022
@Bo98 Bo98 enabled auto-merge April 22, 2022 00:43
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 merged commit a8bb0d6 into Homebrew:master Apr 22, 2022
@Bo98 Bo98 deleted the gcc-major branch April 22, 2022 01:49
@MikeMcQuaid
Copy link
Member

👍🏻 thanks

@github-actions github-actions bot added the outdated PR was locked due to age label May 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bo98 @BrewTestBot @MikeMcQuaid