Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search: drop Homebrew cask tap names from list #13194

Merged
merged 1 commit into from Apr 26, 2022
Merged

search: drop Homebrew cask tap names from list #13194

merged 1 commit into from Apr 26, 2022

Conversation

EricFromCanada
Copy link
Member

@EricFromCanada EricFromCanada commented Apr 26, 2022 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Results in searching a list of tokens from official Homebrew cask taps and fully-qualified tokens from other taps, matching the list when searching formulae. Fixes #13193.

@BrewTestBot
Copy link
Member

Review period will end on 2022-04-27 at 02:21:04 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 26, 2022
@EricFromCanada
search: drop Homebrew cask tap names from list
a4590f3 
Results in searching a list of tokens from official Homebrew cask taps and fully-qualified tokens from other taps, matching the list when searching formulae.
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Apr 26, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Apr 26, 2022
@EricFromCanada EricFromCanada marked this pull request as ready for review April 26, 2022 23:00
@EricFromCanada EricFromCanada merged commit af5ebe5 into Homebrew:master Apr 26, 2022
@EricFromCanada EricFromCanada deleted the search-adjustments branch April 26, 2022 23:01
@github-actions github-actions bot added the outdated PR was locked due to age label May 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brew search shouldn't match on tap name
3 participants
@EricFromCanada @BrewTestBot @MikeMcQuaid