workflows/docker: add OCI metadata #13207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2022-04-28 at 02:44:19 UTC. |
BrewTestBot
added
the
waiting for feedback
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Apr 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we published the ubuntu22.04 image, it wasn't attached to this repository and so it was hidden away in the masses of the org-wide packages.
I've linked the image to the repository manually, but it looks like GitHub looks for and points to documentation on OCI metadata when auto-linking: https://github.com/opencontainers/image-spec/blob/main/annotations.md#pre-defined-annotation-keys
So that there's one less thing to do in the future, might as well add those?
I also forgot to create a Docker Hub repository (since unlike GCR, you need to go do that yourself on the website), but I'll do that and push locally so it should work for 3.4.10.