Fix Rubocop trailing / bug

[danielbayley]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[MikeMcQuaid]

@danielbayley Can you provide a bit more context here? Thanks!

[danielbayley]

@danielbayley Can you provide a bit more context here? Thanks!

Sure. This particular Rubocop rule keeps throwing errors unrelated to the trailing /… For example, if the homepage has string interpolation.

[MikeMcQuaid]

Sure. This particular Rubocop rule keeps throwing errors unrelated to the trailing /… For example, if the homepage has string interpolation.

Can you provide some example casks/PRs/homepages/strings?

[Bo98]

I think I can see what you're getting at but I don't understand the regex change given URI::DEFAULT_PARSER.make_regexp matches all URLs rather than just those without a trailing slash?

Surely the fix for interpolation error is to use the url variable (which you can see defined on line 21) in place of url_node.str_content on line 30?

[danielbayley]

I think I can see what you're getting at but I don't understand the regex change given URI::DEFAULT_PARSER.make_regexp matches all URLs rather than just those without a trailing slash?

Yeah sorry, I misread the regex… That bit was actually unrelated.

Surely the fix for interpolation error is to use the url variable (which you can see defined on line 21) in place of url_node.str_content on line 30?

Yes I thought that was the problem (it should be that anyway), but it’s still throwing undefined method 'metadata' for nil:NilClass errors.

[danielbayley]

Sure. This particular Rubocop rule keeps throwing errors unrelated to the trailing /… For example, if the homepage has string interpolation.

Can you provide some example casks/PRs/homepages/strings?

So in a lot of (tap) casks, I have something like:

repo = "github.com/user/repo"
url "https://#{repo}/releases/download/v#{version}/...zip"
# …
homepage "https://#{repo}#readme"

# … Use of `repo` elsewhere…

[Bo98]

Oh right I see the issue. That'll appear as an invalid URI with interpolated strings no matter what (despite it matching URI::DEFAULT_PARSER.make_regexp) so it was indeed correct to use url_node.str_content.

Does this work?

domain = URI(url_node.str_content).host
return if domain.blank?

[danielbayley]

Oh right I see the issue. That'll appear as an invalid URI with interpolated strings no matter what (despite it matching URI::DEFAULT_PARSER.make_regexp) so it was indeed correct to use url_node.str_content.

Does this work?

domain = URI(url_node.str_content).host
return if domain.blank?

Not quite, but

domain = URI(url_node.str_content).host rescue nil
return if domain.blank?

does…

[Bo98]

LGTM if it works

[MikeMcQuaid]

Thanks again @danielbayley!