Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of nonexistent command brew diy #13230

Merged
merged 1 commit into from May 6, 2022

Conversation

thezeroalpha
Copy link

The output of brew doctor can mention the command brew diy, which was removed in this PR. It's better to remove this output to avoid confusing users. I replaced the text "...deleted or installed with `brew diy`" with "...deleted or installed manually", since manual installation of a program is usually what will lead to this message, but if you think something else would be better, let me know.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
    • no, as far as I'm aware this change doesn't need a test
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @thezeroalpha!

@MikeMcQuaid MikeMcQuaid enabled auto-merge May 3, 2022 08:49
@thezeroalpha
Copy link
Author

Thanks for the encouragement @MikeMcQuaid! Always happy to contribute to free software 😄

The output of `brew doctor` can mention a command `brew diy`, which no
longer exists.
@MikeMcQuaid MikeMcQuaid merged commit 2392078 into Homebrew:master May 6, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants