Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'brew tests --changed' supports changed test files #13237

Merged
merged 1 commit into from May 4, 2022

Conversation

apainintheneck
Copy link
Contributor

@apainintheneck apainintheneck commented May 3, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This updates the brew tests --changed option to support changed test files. Before it would only run tests that correspond to changed library files but wouldn't run tests on changed test files. It also ignores Ruby files that lack the *_spec.rb ending in the test folder like fixtures.

The reason that I made it another method was because the linter was yelling at me about a long block and, to be honest, I agree that it's more readable.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks again @apainintheneck!

@MikeMcQuaid MikeMcQuaid merged commit 6d0bf18 into Homebrew:master May 4, 2022
@apainintheneck apainintheneck deleted the tests-changed-option branch May 29, 2022 02:39
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants