Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print Cask installed error message when --quiet is used #13266

Merged
merged 1 commit into from May 11, 2022

Conversation

xxyzz
Copy link
Contributor

@xxyzz xxyzz commented May 10, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fix #13265

@Bo98
Copy link
Member

Bo98 commented May 10, 2022

There's already code elsewhere to prevent this error being raised:

return if quiet?
raise CaskAlreadyInstalledError, @cask

I believe the issue is quiet: quiet should be in the options hash a few lines up, but is currently missing.

Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Bo98 Bo98 merged commit 4f5f981 into Homebrew:master May 11, 2022
@xxyzz xxyzz deleted the quiet-install branch May 11, 2022 04:39
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew install --cask --quiet is not quiet
2 participants