Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analytics: optionally duplicate to InfluxDB #13356

Merged
merged 1 commit into from
Jan 20, 2023
Merged

analytics: optionally duplicate to InfluxDB #13356

merged 1 commit into from
Jan 20, 2023

Conversation

SMillerDev
Copy link
Member

@SMillerDev SMillerDev commented May 31, 2022 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Starting the work that was open for GSoC but is not part of GSoC

Closes https://github.com/Homebrew/gsoc/issues/46

TODO:

@BrewTestBot
Copy link
Member

Review period will end on 2022-06-01 at 16:05:13 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label May 31, 2022
MikeMcQuaid
MikeMcQuaid reviewed May 31, 2022
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far! Great to see this get some traction.

Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jun 1, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Jun 23, 2022
@SMillerDev SMillerDev force-pushed the feature/influx_analytics branch 2 times, most recently from 8fcfcdd to 14d2e08 Compare June 23, 2022 19:56
@SMillerDev SMillerDev force-pushed the feature/influx_analytics branch 2 times, most recently from b1d84a3 to 79db9ee Compare June 27, 2022 06:58
@carlocab carlocab removed the stale No recent activity label Jun 30, 2022
@carlocab carlocab mentioned this pull request Jun 30, 2022
Closed
@SMillerDev SMillerDev marked this pull request as ready for review July 4, 2022 19:07
@SMillerDev
Copy link
Member Author

The brew domain didn't work for me, we'll have to see if the paid version allows custom domains but otherwise I think we're stuck on the current one.

@MikeMcQuaid
Copy link
Member

The brew domain didn't work for me, we'll have to see if the paid version allows custom domains but otherwise I think we're stuck on the current one.

@SMillerDev This would be a hard blocker on full adoption from me, I'm afraid 😭. I can help when this PR is a bit further along, though.

A suggestion here would be to gate this functionality behind HOMEBREW_NEW_ANALYTICS_TESTING=1 (or something) and then this could be merged and tested before it's ready to be fully rolled out.

@SMillerDev
Copy link
Member Author

This would be a hard blocker on full adoption from me, I'm afraid 😭.

Why would using an external domain for analytics be a blocker for you? Isn't the same situation we have now?

A suggestion here would be to gate this functionality behind HOMEBREW_NEW_ANALYTICS_TESTING=1 (or something) and then this could be merged and tested before it's ready to be fully rolled out.

That's fine by me

@MikeMcQuaid
Copy link
Member

Why would using an external domain for analytics be a blocker for you?

This is not just an external domain but one specific to a particular cloud provider and region.

Isn't the same situation we have now?

We're self-hosting afterwards which means I want to set a higher standard for any future migrations.

@SMillerDev
Copy link
Member Author

We're self-hosting afterwards which means I want to set a higher standard for any future migrations.

The current implementation isn't actually self-hosted. It's using InfluxDB Cloud (DBaaS).

@MikeMcQuaid
Copy link
Member

The current implementation isn't actually self-hosted. It's using InfluxDB Cloud (DBaaS).

Cool. Let's get in touch with them and see what they can do for custom domains. What's the pricing like there?

@SMillerDev
Copy link
Member Author

The pricing is here: https://www.influxdata.com/influxdb-cloud-pricing/

@MikeMcQuaid
Copy link
Member

@SMillerDev Thanks! May want to see if the "annual plan" is better and will need to watch our cardinality.

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Aug 4, 2022
@SMillerDev SMillerDev force-pushed the feature/influx_analytics branch 4 times, most recently from 246f5ae to 96add4c Compare December 5, 2022 12:56
@SMillerDev
Copy link
Member Author

@MikeMcQuaid actually forgot to update here. But we also can't do a vanity domain if we setup through Google Cloud. That would only be available if we self-host which I'd like to avoid. Most of the other TODO items are now done.

@MikeMcQuaid MikeMcQuaid changed the title analytics: switch to InfluxDB for logging analytics: optionally duplicate to InfluxDB Dec 27, 2022
MikeMcQuaid
MikeMcQuaid reviewed Dec 27, 2022
View reviewed changes
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
@SMillerDev SMillerDev force-pushed the feature/influx_analytics branch 2 times, most recently from 50e6a27 to fde8d2c Compare December 28, 2022 20:38
@SMillerDev
Copy link
Member Author

Should analytics report being Linuxbrew on Linux? I thought it was all Homebrew now?

@MikeMcQuaid
Copy link
Member

Should analytics report being Linuxbrew on Linux? I thought it was all Homebrew now?

Yes, all Homebrew and a single analytics "bucket" with differing OS would be ideal.

@SMillerDev SMillerDev force-pushed the feature/influx_analytics branch 2 times, most recently from c0789f0 to 654f147 Compare December 29, 2022 19:42
MikeMcQuaid
MikeMcQuaid approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once suggested changes are applied and tests are 🟢. Sorry for all the back-and-forth.

Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
@SMillerDev
Copy link
Member Author

@MikeMcQuaid any suggestions what I can do about the timeouts?

@MikeMcQuaid
Copy link
Member

@SMillerDev For now: ignore them. Are you ready to merge as-is? If so: I can do it manually.

@SMillerDev
Copy link
Member Author

Yeah, I think this is ready to merge.

@MikeMcQuaid MikeMcQuaid merged commit 1588f6c into Homebrew:master Jan 20, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@Rylan12 Rylan12 Rylan12 left review comments

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
in progress Maintainers are working on this outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replacing Google Analytics
5 participants
@SMillerDev @BrewTestBot @MikeMcQuaid @Rylan12 @carlocab