Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused parser option required_for #13398

Merged
merged 1 commit into from Jun 9, 2022

Conversation

apainintheneck
Copy link
Contributor

@apainintheneck apainintheneck commented Jun 8, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I was looking at the parser and I was surprised to see that there is a :required_for option available for both switch and flag. Unlike :depends_on this option is not used anywhere so I figured it could be removed.

@MikeMcQuaid MikeMcQuaid merged commit 39f30d7 into Homebrew:master Jun 9, 2022
@MikeMcQuaid
Copy link
Member

Good catch, thanks again @apainintheneck!

@apainintheneck apainintheneck deleted the remove-required-for branch June 9, 2022 19:45
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants