Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask/installer.rb: stop including Staged module #13546

Merged

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The original pr #13516 was closed because of failing tests which were resolved in pr #13545.

The idea here is to tackle the todo on line 32 of cask/installer.rb related to the including of cask/staged. There are two methods found in cask/staged which are #set_permissions and #set_ownership. Neither of these methods are called throughout the entire brew codebase. These methods are made available through the preflight, postflight and uninstall_postflight cask stanzas where a quick search shows they do get used and staged is now required in each of those dsl files.

@BrewTestBot
Copy link
Member

Review period will end on 2022-07-13 at 00:58:44 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 12, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Jul 12, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 12, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Aug 2, 2022
@MikeMcQuaid
Copy link
Member

@apainintheneck good to merge when you are! if you don't have merge rights yet: remind me and I'll grant them

@github-actions github-actions bot removed the stale No recent activity label Aug 2, 2022
@apainintheneck
Copy link
Contributor Author

@MikeMcQuaid Honestly I forgot about this PR. I'll merge it in.

@apainintheneck apainintheneck merged commit ba7e146 into Homebrew:master Aug 3, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
@apainintheneck apainintheneck deleted the remove-staged-from-cask branch January 3, 2023 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants