cask/installer.rb: stop including Staged module #13546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?The original pr #13516 was closed because of failing tests which were resolved in pr #13545.
The idea here is to tackle the todo on line 32 of
cask/installer.rb
related to the including ofcask/staged
. There are two methods found incask/staged
which are#set_permissions
and#set_ownership
. Neither of these methods are called throughout the entire brew codebase. These methods are made available through thepreflight
,postflight
anduninstall_postflight
cask stanzas where a quick search shows they do get used and staged is now required in each of those dsl files.