Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: delete Homebrew-linuxbrew-core-Maintainer-Guide.md #13624

Merged
merged 1 commit into from Aug 1, 2022
Merged

docs: delete Homebrew-linuxbrew-core-Maintainer-Guide.md #13624

merged 1 commit into from Aug 1, 2022

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Jul 31, 2022

In e112054 this file was emptied,
but should have been deleted instead.
Nothing references this file anymore

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@iMichka
docs: delete Homebrew-linuxbrew-core-Maintainer-Guide.md
e28a102 
In e112054 this file was emptied,
but should have been deleted instead.
Nothing references this file anymore
@BrewTestBot
Copy link
Member

Review period will end on 2022-08-02 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jul 31, 2022
@iMichka iMichka requested a review from MikeMcQuaid July 31, 2022 21:03
issyl0
issyl0 approved these changes Jul 31, 2022
View reviewed changes
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange.

@BrewTestBot BrewTestBot added waiting for feedback Merging is blocked until sufficient time has passed for review and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Aug 1, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Aug 1, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 1, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
Copy link
Member

Thanks for this @iMichka!

@MikeMcQuaid MikeMcQuaid merged commit 4baff3e into Homebrew:master Aug 1, 2022
@iMichka iMichka deleted the core branch August 1, 2022 19:52
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@issyl0 issyl0 issyl0 approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iMichka @BrewTestBot @MikeMcQuaid @issyl0 @Rylan12