Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew search --verbose to tell about brew desc #13667

Merged
merged 2 commits into from Aug 9, 2022

Conversation

abitrolly
Copy link
Contributor

@abitrolly abitrolly commented Aug 9, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

brew search doesn't include package descriptions in the output, so even when a package matches, it is hard to tell if it does what is needed. In the proposal to add package descriptions into search -v output #11932 I've discovered that there is a separate brew desc search command that does exactly this. So per discussion #11932 (comment) this is the PR that adds hint to use brew desc if search is supplied with --verbose.

(hit this problem again today and forgot about desc already)

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far! Some suggested wording tweaks.

Library/Homebrew/cmd/search.rb Outdated Show resolved Hide resolved
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@abitrolly abitrolly changed the title brew search --vebose to tell about brew desc brew search --verbose to tell about brew desc Aug 9, 2022
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @abitrolly!

@abitrolly
Copy link
Contributor Author

Linux test failed with GitHub API Error: You have exceeded a secondary rate limit.

@MikeMcQuaid MikeMcQuaid merged commit 7fcc30c into Homebrew:master Aug 9, 2022
@abitrolly abitrolly deleted the search-v-desc branch August 9, 2022 19:14
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 9, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants