formula: add optional source and target args to #rpath
#13722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are about 10 formulae which need a bit more flexibility from `#rpath`. Most of them use `Pathname#relative_path_from`, so we can replace those instances with a call to `#rpath` instead once `#rpath` knows how to handle this.
|
Review period will end on 2022-08-22 at 09:36:26 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
approved these changes
Aug 19, 2022
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Aug 22, 2022
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
Aug 25, 2022
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
Aug 25, 2022
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
Aug 25, 2022
`rpath` can now passed arguments to compute the correct `RPATH` entry on both macOS and Linux. See Homebrew/brew#13722.
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Aug 27, 2022
`rpath` can now passed arguments to compute the correct `RPATH` entry on both macOS and Linux. See Homebrew/brew#13722. Closes #108857. Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Aug 27, 2022
See Homebrew/brew#13722. Closes #108859. Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Aug 27, 2022
See Homebrew/brew#13722. Closes #108858. Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?There are about 10 formulae which need a bit more flexibility from
#rpath. Most of them usePathname#relative_path_from, so we canreplace those instances with a call to
#rpathinstead once#rpathknows how to handle this.