formula_auditor: skip rename audit for glib-utils
#13725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am removing `glib-utils` in (1) Homebrew/homebrew-core#108307, and all `glib-utils` dependencies in (2) Homebrew/homebrew-core#108497. This audit prevents me from proceeding with (1) without rebuilding all the formulae modified in (2). I don't think that is needed, so I'd like to exempt `glib-utils` from the rename audit instead. To give you a clearer idea of how I plan to do this, this is the order of events: 1. Merge this change. 2. Merge Homebrew/homebrew-core#108307. 3. Merge Homebrew/homebrew-core#108497. 4. Revert this change. This should allow us to get rid of `glib-utils` and its accompanying hacks without having to rebuild dozens of formulae needlessly.
|
Review period will end on 2022-08-23 at 00:00:00 UTC. |
BrewTestBot
added
the
waiting for feedback
6 tasks
MikeMcQuaid
approved these changes
Aug 22, 2022
MikeMcQuaid
added
the
critical
BrewTestBot
removed
the
waiting for feedback
|
Review period skipped due to |
BrewTestBot
approved these changes
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?I am removing
glib-utilsin (1) Homebrew/homebrew-core#108307, and allglib-utilsdependencies in (2) Homebrew/homebrew-core#108497.This audit prevents me from proceeding with (1) without rebuilding all
the formulae modified in (2). I don't think that is needed, so I'd like
to exempt
glib-utilsfrom the rename audit instead.To give you a clearer idea of how I plan to do this, this is the order
of events:
glib-utilsdependencies. homebrew-core#108497.This should allow us to get rid of
glib-utilsand its accompanyinghacks without having to rebuild dozens of formulae needlessly.