Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/deps: improve switch names. #13775

Merged
merged 1 commit into from
Aug 31, 2022
Merged

cmd/deps: improve switch names. #13775

merged 1 commit into from
Aug 31, 2022

Conversation

MikeMcQuaid
Copy link
Member

The previous -n and --1 made both the code and the help harder to read and follow.

@BrewTestBot
Copy link
Member

Review period will end on 2022-08-31 at 12:19:26 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 30, 2022
@EricFromCanada
Copy link
Member

Can --1 be changed to -1, since that form also works, and would allow it to be retained in the man page output as the short flag.

carlocab
carlocab approved these changes Aug 30, 2022
View reviewed changes
Library/Homebrew/cmd/deps.rb Outdated Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member Author

Can --1 be changed to -1, since that form also works, and would allow it to be retained in the man page output as the short flag.

@EricFromCanada I don't want to break backwards comparability here but I'm game for adding -1 as well as --1? Could you make an inline suggestion?

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 31, 2022
@BrewTestBot
Copy link
Member

Review period ended.

EricFromCanada
EricFromCanada approved these changes Aug 31, 2022
View reviewed changes
Library/Homebrew/cmd/deps.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/deps.rb Outdated Show resolved Hide resolved
@MikeMcQuaid @EricFromCanada @carlocab
cmd/deps: improve switch names.
fd432aa 
The previous `-n` and `--1` made both the code and the help harder to
read and follow.

Co-authored-by: Eric Knibbe <enk3@outlook.com>
Co-Authored-By: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@MikeMcQuaid MikeMcQuaid merged commit 0cf999e into master Aug 31, 2022
@MikeMcQuaid MikeMcQuaid deleted the brew_deps_args branch August 31, 2022 16:53
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EricFromCanada EricFromCanada EricFromCanada approved these changes

@carlocab carlocab carlocab approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikeMcQuaid @BrewTestBot @EricFromCanada @carlocab