Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shims/gems/rubocop: handle when brew isn't in PATH. #13776

Merged
merged 1 commit into from
Aug 30, 2022
Merged

shims/gems/rubocop: handle when brew isn't in PATH. #13776

merged 1 commit into from
Aug 30, 2022

Conversation

MikeMcQuaid
Copy link
Member

Instead, figure out where $HOMEBREW_PREFIX/bin should be and use that.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Aug 30, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid
shims/gems/rubocop: handle when brew isn't in PATH.
5b8bc14 
Instead, figure out where `$HOMEBREW_PREFIX/bin` should be and use that.
@MikeMcQuaid MikeMcQuaid merged commit 2d79b4b into master Aug 30, 2022
@MikeMcQuaid MikeMcQuaid deleted the rubocop_fixes branch August 30, 2022 13:19
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @BrewTestBot