Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend/os/linux: improve glibc, gcc dependency handling. #13778

Merged
merged 1 commit into from
Aug 30, 2022
Merged

extend/os/linux: improve glibc, gcc dependency handling. #13778

merged 1 commit into from
Aug 30, 2022

Conversation

MikeMcQuaid
Copy link
Member

  • Add more early return checks
  • Move to a recursive approach for more readability and avoiding a counter that we need to bump
  • Perform more caching
  • Keep class variable usage isolated into specific methods

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Aug 30, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

carlocab
carlocab approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@MikeMcQuaid
extend/os/linux: improve glibc, gcc dependency handling.
1f709d3 
- Add more early return checks
- Move to a recursive approach for more readability and avoiding a
  counter that we need to bump
- Perform more caching
- Keep class variable usage isolated into specific methods
@MikeMcQuaid MikeMcQuaid force-pushed the improve_glibc_gcc_dep_handling branch from fc48092 to 1f709d3 Compare August 30, 2022 12:54
@MikeMcQuaid MikeMcQuaid merged commit d5b9d0e into master Aug 30, 2022
@MikeMcQuaid MikeMcQuaid deleted the improve_glibc_gcc_dep_handling branch August 30, 2022 13:28
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 left review comments

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MikeMcQuaid @BrewTestBot @Bo98 @carlocab