Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/deps: drop --installed requirement for --formula/--cask #13784

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

EricFromCanada
Copy link
Member

It appears the requirement was originally imposed in #9414 because only the --installed logic checked for --formula or --cask. But with the addition of named_args, that check is done automatically.

Fixes #13592.

@BrewTestBot
Copy link
Member

Review period will end on 2022-09-01 at 18:25:51 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 31, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 1, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 1, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit 48b579a into Homebrew:master Sep 1, 2022
@EricFromCanada EricFromCanada deleted the deps-drop-requirement branch September 1, 2022 13:41
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew deps fails with --formula and emits a warning without it
3 participants