Improve brew update with HOMEBREW_INSTALL_FROM_API
#13795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2022-09-05 at 06:20:23 UTC. |
BrewTestBot
added
the
waiting for feedback
14 tasks
MikeMcQuaid
added
the
critical
BrewTestBot
removed
the
waiting for feedback
|
Review period skipped due to |
BrewTestBot
approved these changes
Sep 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies some
brew updaterelated logic to work better withHOMEBREW_INSTALL_FROM_API. Currently, if you haveHOMEBREW_INSTALL_FROM_APIset,brew updatewill never update the core and cask taps. We want this to remain, but also want a way for developers to continue maintaining homebrew/core and homebrew/cask. So, this PR modifiesbrew updateso that it does update the core and cask taps when someone withHOMEBREW_DEVELOPERset runsbrew update. As before.brew update --auto-updatewill not update the core and cask taps.Additionally, I updated the call in
brew updatethat updates the cached formula JSON file so that it uses--time-condlike we do inHomebrew::API::Formula.all_formulaeto avoid unnecessary downloading when the file hasn't changed.Finally, I made a small change to
Homebrew::API::Formula.all_formulaeto remove a duplicated file path.