Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore renamed formulae when checking for unversioned formulae #13799

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Ignore renamed formulae when checking for unversioned formulae #13799

merged 1 commit into from
Sep 5, 2022

Conversation

apainintheneck
Copy link
Contributor

@apainintheneck apainintheneck commented Sep 3, 2022 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This fixes #13772.

There is an audit for versioned formulae that makes sure an unversioned formula of the same name exists already. This ignores that check when we explicitly removed the unversioned formula by checking if it was renamed first.

Also, there is no need to check for formula.tap because formula.core_formula? guarantees the presence of formula.tap.

@apainintheneck
Ignore renamed formulae when checking for unversioned formulae
bb1c783 
There is an audit for versioned formulae that makes sure
an unversioned formulae of the same name exists already.
This ignores that check when we exlicitly removed the
unversioned formula by checking if it was renamed.

Also, there is no need to check for formula.tap because
formula.core_formula? guarantees the presence of formula.tap.
@apainintheneck apainintheneck added the bug Reproducible Homebrew/brew bug label Sep 3, 2022
@BrewTestBot
Copy link
Member

Review period will end on 2022-09-06 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 3, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 5, 2022
@MikeMcQuaid
Copy link
Member

Great work, thanks @apainintheneck!

@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 5, 2022
@carlocab carlocab merged commit 6def5fc into Homebrew:master Sep 5, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2022
@apainintheneck apainintheneck deleted the ignore-missing-unversioned-formula-after-rename branch January 3, 2023 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@carlocab carlocab carlocab approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
bug Reproducible Homebrew/brew bug critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew audit postgresql@14 throws spurious warning
5 participants
@apainintheneck @BrewTestBot @MikeMcQuaid @carlocab @Rylan12