dev-cmd/pr-pull: avoid expensive search API calls #13801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Sep 3, 2022
Bo98
force-pushed
the
pr-pull-github-api
branch
from
e13721a
to
00ede4a
Compare
Bo98
force-pushed
the
pr-pull-github-api
branch
from
00ede4a
to
04f6f53
Compare
Rylan12
approved these changes
Sep 3, 2022
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search API has a rate limit of 30 per minute. This is far too small for something invoked on every merge in both Homebrew/core and Homebrew/cask.
Instead let's not use the search API at all and use the Issues REST API.
As a bonus: add a check to avoid an unnecessary
GitHub.get_pull_request_changed_filesREST API call when there is no long PRs to check.