bump-cask-pr: cleanup handling of multiple hashes #13802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rylan12
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Sep 4, 2022
MikeMcQuaid
approved these changes
Sep 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13773
This PR cleans up the handling of multiple hashes for bumping casks. Here is the approach that I've taken: first, check if the current hash is
:no_check. If it's not, go through each arch/language configuration one at a time (e.g. Intel en, ARM en, Intel fr, ARM fr) to find the new hash values and add them to the replacement pairs. Then, we use.uniqon the replacement pairs to remove duplicates before applying each replacement. I think this is a simpler way to handle both arch and language differences in the same place.