Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/fetch: rename fetch_failed to fetch_tries. #13812

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Sep 6, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This makes the code substantially easier to understand. Follow-up to #13807.

This makes the code substantially easier to understand. Follow-up to Homebrew#13807.
@BrewTestBot
Copy link
Member

Review period will end on 2022-09-07 at 10:37:29 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 6, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 6, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 6, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@carlocab carlocab merged commit db921d8 into Homebrew:master Sep 6, 2022
@carlocab carlocab deleted the fetch-tries branch September 6, 2022 11:13
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants