Include loaded_from_api key in Tab
#13842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2022-09-13 at 00:00:00 UTC. |
14 tasks
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
added
the
critical
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Sep 12, 2022
MikeMcQuaid
reviewed
Sep 12, 2022
MikeMcQuaid
approved these changes
Sep 15, 2022
|
Perfect, thanks again @Rylan12! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
loaded_from_apiitem to a formula'sTab. Whether the formula was loaded from the API or not is determined by checking the formula namespace to see if it starts withFormulaNamespaceAPIwhich would only be the case when loading from the API. This change will allow us to check whether formulae were installed from the API or not which could be helpful for debugging or other things like that.I'd also like to note this for casks somehow too, but I'm not totally sure what the best way to do that is. Maybe put it in
config.jsonsomehow?