Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds brew docs to close #13834 #13844

Merged
merged 3 commits into from Sep 12, 2022

Conversation

troymccabe
Copy link
Contributor

@troymccabe troymccabe commented Sep 12, 2022

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Per the discussion in #13834, here's an MVP for opening docs in a browser.

Fixes #13834

Library/Homebrew/cmd/docs.rb Outdated Show resolved Hide resolved
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @troymccabe!

Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
@MikeMcQuaid MikeMcQuaid merged commit c7bd51b into Homebrew:master Sep 12, 2022
@jmfayard
Copy link

🎉 Thanks for implementing my issue @troymccabe!

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew docs as an alias for open https://docs.brew.sh
4 participants