Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cask: automatically add cask audits #13857

Merged
merged 3 commits into from Sep 15, 2022
Merged

Cask: automatically add cask audits #13857

merged 3 commits into from Sep 15, 2022

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Reverts the revert in #13813 and disables some typechecks.

@BrewTestBot
Copy link
Member

Review period will end on 2022-09-14 at 09:21:57 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 13, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 14, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@SMillerDev
Copy link
Member Author

Super confused how it managed to work before when referencing nil for url or version, but I guess I'll add guards for that.

@SMillerDev
Copy link
Member Author

Okay, here goes attempt number 2

@SMillerDev SMillerDev merged commit 67c6cae into Homebrew:master Sep 15, 2022
@SMillerDev SMillerDev deleted the feature/cask/auto_audit branch September 21, 2022 13:20
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SMillerDev @BrewTestBot @MikeMcQuaid