Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula_auditor: disallow SSPL. #13858

Merged
merged 2 commits into from Sep 13, 2022
Merged

formula_auditor: disallow SSPL. #13858

merged 2 commits into from Sep 13, 2022

Conversation

carlocab
Copy link
Member

The SSPL is not an open-source license, but it is recognised by SPDX.

See Homebrew/homebrew-core#109801.

@carlocab
formula_auditor: disallow SSPL.
dfd5895 
The SSPL is not an open-source license, but it is recognised by SPDX.

See Homebrew/homebrew-core#109801.
@BrewTestBot
Copy link
Member

Review period will end on 2022-09-14 at 11:23:40 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 13, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 13, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 13, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

MikeMcQuaid
MikeMcQuaid reviewed Sep 13, 2022
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to land immediately but we should use the isOsiApproved (false for SSPL) for stuff to automatically reject.

@carlocab carlocab merged commit 65da808 into Homebrew:master Sep 13, 2022
@carlocab carlocab deleted the sspl branch September 13, 2022 12:46
carlocab added a commit to carlocab/brew that referenced this pull request Sep 13, 2022
@carlocab
formula_auditor: use SPDX data to check for open source licenses.
010c18c 
Follow-up to Homebrew#13858.
@carlocab carlocab mentioned this pull request Sep 13, 2022
Closed
7 tasks
@carlocab
Copy link
Member Author

#13859

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carlocab @BrewTestBot @MikeMcQuaid