New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource: automatic determine mirrors for `glibc-bootstrap` and PyPI resources #13875

Merged

MikeMcQuaid merged 3 commits into Homebrew:master from XuehaiPan:resource-url-mirrors-mapping

Sep 18, 2022

Contributor

XuehaiPan commented Sep 15, 2022

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew typecheck with your changes locally?
Have you successfully run brew tests with your changes locally?

Alternative to #13868.

Resolves Homebrew/glibc-bootstrap#6
Closes #13868

XuehaiPan force-pushed the resource-url-mirrors-mapping branch from a9ef3ae to dc828bb Compare

September 15, 2022 14:18

MikeMcQuaid reviewed

View reviewed changes

Member

MikeMcQuaid left a comment

I prefer this approach, nice work!

Library/Homebrew/resource.rb Outdated Show resolved Hide resolved

Library/Homebrew/resource.rb Outdated Show resolved Hide resolved

Library/Homebrew/env_config.rb Outdated Show resolved Hide resolved

Library/Homebrew/resource.rb Outdated Show resolved Hide resolved

XuehaiPan force-pushed the resource-url-mirrors-mapping branch 6 times, most recently from 2a2b2a0 to 9b527a4 Compare

September 15, 2022 15:16

MikeMcQuaid reviewed

View reviewed changes

Library/Homebrew/env_config.rb Outdated Show resolved Hide resolved

Library/Homebrew/env_config.rb Outdated Show resolved Hide resolved

bin/brew Outdated Show resolved Hide resolved

MikeMcQuaid reviewed

View reviewed changes

Library/Homebrew/env_config.rb Outdated Show resolved Hide resolved

MikeMcQuaid reviewed

View reviewed changes

Library/Homebrew/env_config.rb Outdated Show resolved Hide resolved

XuehaiPan force-pushed the resource-url-mirrors-mapping branch from f207200 to a371682 Compare

September 15, 2022 16:44

MikeMcQuaid reviewed

View reviewed changes

Library/Homebrew/env_config.rb Outdated Show resolved Hide resolved

Library/Homebrew/env_config.rb Outdated Show resolved Hide resolved

Library/Homebrew/resource.rb Outdated Show resolved Hide resolved

Library/Homebrew/resource.rb Outdated Show resolved Hide resolved

Library/Homebrew/test/env_config_spec.rb Outdated Show resolved Hide resolved

bin/brew Outdated Show resolved Hide resolved

XuehaiPan commented

View reviewed changes

Library/Homebrew/env_config.rb

@@ @@ -318,6 +318,10 @@ module EnvConfig @@
                                    "outdated.",
                       boolean:     true,
                     },
+                    HOMEBREW_PIP_INDEX_URL:                    {
+                      description:  "If set, `brew install <formula>` will use this URL to download PyPI package resources.",
+                      default_text: "`https://pypi.org/simple`.",

Contributor Author

XuehaiPan Sep 15, 2022 •

edited

This would be unset by default and will not be initialized from PIP_INDEX_URL. The user need to set a new Homebrew-specific variable.

https://pypi.org/packages and https://files.pythonhosted.org/packages (this one is what we use in formulae) are mutually identical. We use https://pypi.org/simple (suffix as simple rather than package) in the docs here because https://files.pythonhosted.org/simple is private.

XuehaiPan added 2 commits

September 16, 2022 01:50


          resource: automatic determine mirrors for glibc-bootstrap

46b3d24


          resource: automatic determine mirrors for PyPI resources

d3093cd

XuehaiPan force-pushed the resource-url-mirrors-mapping branch from abed698 to d3093cd Compare

September 15, 2022 17:57

XuehaiPan requested a review from MikeMcQuaid

September 15, 2022 17:59

MikeMcQuaid approved these changes

View reviewed changes

Member

MikeMcQuaid commented Sep 16, 2022

Thanks again @XuehaiPan!

MikeMcQuaid enabled auto-merge

September 16, 2022 07:48

auto-merge was automatically disabled

September 17, 2022 08:40

Head branch was pushed to by a user without write access


          cask/audit: fix audit error when homepage is missing

46736c5

XuehaiPan force-pushed the resource-url-mirrors-mapping branch from cea2166 to 46736c5 Compare

September 17, 2022 08:43

MikeMcQuaid approved these changes

View reviewed changes

MikeMcQuaid merged commit 8a4826a into Homebrew:master

Member

MikeMcQuaid commented Sep 18, 2022

Thanks again @XuehaiPan!

XuehaiPan deleted the resource-url-mirrors-mapping branch

September 18, 2022 12:16

XuehaiPan mentioned this pull request

[镜像请求] Homebrew/glibc-bootstrap tuna/issues#1586

Closed

6 tasks

github-actions bot added the outdated label

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.